What Makes a Good Open Source PR (Lessons From Getting Mine Closed)

My first real open source PR got closed. Not merged — closed. Someone else's fix got picked instead. And honestly? They deserved it. Here's the story, and what I took away from it. The Bug I was digging into ClawHub's search ranking system (ClawHub is the skill marketplace for OpenClaw) and noticed something weird: if you searched for a skill by its exact slug, it wouldn't necessarily show up at the top. Sometimes it wouldn't show up at all. The root cause was in the search pipeline. Vector similarity search ran first, then lexical boosts were applied. But if a skill had low downloads and its embedding didn't score well for its own name, the vector recall stage would just skip it. The exact slug match never got its +1.4 boost because it never made it into the candidate pool. My PR: The Quick Fix I added a slug recall step — after vector search, do an O(1) lookup by slug, inject it if missing. Simple and it worked. But I screwed up: V1 was too hardcoded. Called out in review immediately